Skip to content

Commit

Permalink
Minor css fixes for activity log settings (#2752)
Browse files Browse the repository at this point in the history
* Minor css fixes for activity log settings

* Add copy and adjust modal as per design
  • Loading branch information
nelsonkopliku authored and balanza committed Jul 9, 2024
1 parent 446c5bb commit 3bc6d29
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 11 deletions.
11 changes: 4 additions & 7 deletions assets/js/common/ActivityLogsConfig/ActivityLogsConfig.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -35,17 +35,14 @@ function ActivityLogsConfig({ retentionTime, onEditClick = noop }) {
<div>
<h2 className="text-2xl font-bold inline-block">Activity Logs</h2>
<span className="float-right">
<Button
className="mr-2"
type="primary-white-fit"
size="small"
onClick={onEditClick}
>
<Button type="primary-white-fit" size="small" onClick={onEditClick}>
Edit Settings
</Button>
</span>
</div>
<p className="mt-3 mb-3 text-gray-500" />
<p className="mt-3 mb-3 text-gray-500">
Configure data retention times for log entries.
</p>

<div className="grid grid-cols-6 mt-5 items-center">
<div className="font-bold mb-3">Retention Time</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ function TimeSpan({ time: initialTime, error = false, onChange = noop }) {
const [time, setTime] = useState(initialTime);

return (
<div className="flex items-center space-x-2">
<div className="w-2/4 pb-4">
<div className="flex items-center space-x-2">
<div className="w-1/4 pt-1">
<InputNumber
value={time.value}
className="!h-8"
Expand All @@ -45,7 +45,7 @@ function TimeSpan({ time: initialTime, error = false, onChange = noop }) {
}}
/>
</div>
<div className="w-2/4 ">
<div className="flex w-1/4">
<Select
optionsName=""
options={timeUnitOptions}
Expand Down Expand Up @@ -93,7 +93,15 @@ function ActivityLogsSettingsModal({
const genericError = toGenericErrorMessage(errors);

return (
<Modal title="Enter Activity Logs Settings" open={open} onClose={onCancel}>
<Modal
className="!w-3/4 !max-w-3xl"
title="Enter Activity Logs Settings"
open={open}
onClose={onCancel}
>
<div className="text-gray-500">
Set the data retention times for log entries.
</div>
<div className="grid grid-cols-6 my-5 gap-6">
<Label className="col-span-2" required>
Retention Time
Expand Down

0 comments on commit 3bc6d29

Please sign in to comment.