Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed double-free when destroying a copied Tlsh instance #90

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maikemoto
Copy link

Summary

Sometimes, double-free occurs when destroying a copied Tlsh instance.
A cause of the issue is when the Tlsh instance is assigned to another instance, default TlshImpl's operator=() method copies dynamically allocated memory areas by shallow copy. Therefore, when both copy source and copy destination are freed, same areas are freed twice.
This change solves the issue by copying the areas by deep copy, and makes Tlsh instances copyable.

Changes

Implement operator=(const TlshImpl&) method in the Tlsh class. The method allocates/frees dynamically allocated memory areas as necessary, and then copies data from source instance by deep copy.

Remark

TlshImpl's copy constructor has the same issue. However, the constructor is never used, so there is unnecessary to implement it.

Reproduction code of the issue

Tlsh* tlsh[5];

tlsh[0] = new Tlsh();
tlsh[1] = new Tlsh(*tlsh[0]);
for (unsigned char i = 0; i < 255; ++i) tlsh[0]->update(&i, 1);
tlsh[2] = new Tlsh(*tlsh[0]);
tlsh[0]->final();
tlsh[3] = new Tlsh(*tlsh[0]);
tlsh[0]->getHash();
tlsh[4] = new Tlsh(*tlsh[0]);

delete tlsh[0];	// success.
delete tlsh[1];	// success.
delete tlsh[2];	// failed because tlsh1->a_bucket is double-freed.
delete tlsh[3];	// success.
delete tlsh[4];	// failed because tlsh1->lsh_code is double-freed.

# Summary
Sometimes, double-free occurs when destroying a copied Tlsh instance.
A cause of the issue is when the Tlsh instance is assigned to another instance, default TlshImpl's operator=() method copies dynamically allocated memory areas by shallow copy. Therefore, when both copy source and copy destination are freed, same areas are freed twice.
This change solves the issue by copying the areas by deep copy, and makes Tlsh instances copyable.

# Changes
Implement operator=(const TlshImpl&) method in the Tlsh class. The method allocates/frees dynamically allocated memory areas as necessary, and then copies data from source instance by deep copy.

# Remark
TlshImpl's copy constructor has the same issue. However, the constructor is never used, so there is unnecessary to implement it.

# Reproduction code of the issue
```
Tlsh* tlsh[5];

tlsh[0] = new Tlsh();
tlsh[1] = new Tlsh(*tlsh[0]);
for (unsigned char i = 0; i < 255; ++i) tlsh[0]->update(&i, 1);
tlsh[2] = new Tlsh(*tlsh[0]);
tlsh[0]->final();
tlsh[3] = new Tlsh(*tlsh[0]);
tlsh[0]->getHash();
tlsh[4] = new Tlsh(*tlsh[0]);

delete tlsh[0];	// success.
delete tlsh[1];	// success.
delete tlsh[2];	// failed because tlsh1->a_bucket is double-freed.
delete tlsh[3];	// success.
delete tlsh[4];	// failed because tlsh1->lsh_code is double-freed.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant