fix(react/theme): correct the check for empty cssVariables to avoid logical errors

[cheton]

PR Type

Bug fix

---

Description

• Fixed a logical error in the CSSVariables component by correcting the condition to check for empty cssVariables.
• Ensured that the length of Object.keys(cssVariables) is used to determine if cssVariables is empty.

---

Changes walkthrough 📝

	Relevant files
Bug fix	CSSVariables.js Fix logical error in `cssVariables` emptiness check            packages/react/src/theme/CSSVariables.js Corrected the condition to check for empty cssVariables. Changed Object.keys(cssVariables) === 0 to Object.keys(cssVariables).length === 0. +1/-1

---

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

[codesandbox]

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

[changeset-bot]

🦋 Changeset detected

Latest commit: d0dc04b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@tonic-ui/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codiumai-pr-agent-free]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Logic Validation Verify that ensurePlainObject properly handles edge cases like null or undefined values for cssVariables before Object.keys is called

[codiumai-pr-agent-free]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
General	Simplify empty object check using a more idiomatic JavaScript pattern The condition Object.keys(cssVariables).length === 0 is correct but could be simplified using the more idiomatic Object.keys(cssVariables).length check. Consider using a direct empty object check with Object.keys(cssVariables).length for better readability and maintainability. packages/react/src/theme/CSSVariables.js [9] -if (!rootSelector || Object.keys(cssVariables).length === 0) { +if (!rootSelector || !Object.keys(cssVariables).length) { Apply this suggestion Suggestion importance[1-10]: 3 Why: While the suggestion to use !Object.keys(cssVariables).length is valid and more idiomatic in JavaScript, it's a minor stylistic improvement that doesn't significantly impact functionality or readability of the code.	3

💡 Need additional feedback ? start a PR chat

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

[trendmicro-frontend-bot]

Tonic UI Demo

On 2024-12-05 06:23:54 +0000, PR #953 (d0dc04b) was successfully deployed. You can view it at the following link:
https://trendmicro-frontend.github.io/tonic-ui-demo/react/pr-953/

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.44%. Comparing base (edc8823) to head (d0dc04b).
Report is 1 commits behind head on v2.

Additional details and impacted files

@@            Coverage Diff             @@
##               v2     #953      +/-   ##
==========================================
- Coverage   78.45%   78.44%   -0.02%     
==========================================
  Files         406      406              
  Lines        6693     6693              
==========================================
- Hits         5251     5250       -1     
- Misses       1442     1443       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.