feat: enhance OverflowTooltip overflow detection for precise handling of non-integral width or height
#806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a6ef610:
|
Tonic UI Demo
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #806 +/- ##
==========================================
+ Coverage 71.35% 71.40% +0.05%
==========================================
Files 374 374
Lines 6256 6267 +11
==========================================
+ Hits 4464 4475 +11
Misses 1792 1792
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cheton
force-pushed
the
fix-overflowtooltip-issue
branch
from
695b221 to
00a9bc6
Compare
cheton
changed the title
OverflowTooltip issue in boundary test scenarios
cheton
force-pushed
the
fix-overflowtooltip-issue
branch
from
00a9bc6 to
c8681c6
Compare
cheton
force-pushed
the
fix-overflowtooltip-issue
branch
from
c8681c6 to
3c9ad7e
Compare
cheton
approved these changes
Nov 15, 2023
cheton
changed the title
OverflowTooltip issue in boundary test scenariosOverflowTooltip component for precise handling of non-integral width or height
cheton
changed the title
OverflowTooltip component for precise handling of non-integral width or heightOverflowTooltip overflow detection for precise handling of non-integral width or height
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The column width is set to 180px, and the text is 'V1ES-Workload Security'.
The length of the text (including cell padding of 12px on each side), it exactly matches the 180px width.
This results in scrollWidth === clientWidth (no OverflowTooltip displayed), but the style is truncated.
Env
MacOS Ventura 13.6
Chrome 119.0.6045.123
Solution
Using getBoundingClientRect / getClientRects to obtain width with fractional precision instead of scrollWidth
CodeSandbox: https://codesandbox.io/s/overflowtooltip-issue-7vjsls?file=/src/CustomOverflowTooltip/CustomOverflowTooltip.js