-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Truncated long value names in confirmation window #8670
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to keep the ?
on the same line.
> | ||
{email} | ||
</strong> | ||
<br/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the newline after the email?
I think it's better to have it on the same line...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I was wondering about that. Okay, I'll move the question mark to the same line as the email.
A related question: In your opinion, what should the expected behavior be?
Currently, long emails wrap to a new line, while short emails remain on the same line. Guy thinks the behavior should be the same for short, long, and overly long (requiring truncation) emails in terms of the line on which they appear.
What do you think should be the standard behavior for all cases?
I believe it would be better if all emails—whether short, long, or too long (requiring truncation)—appear on a new line, with the question mark positioned next to them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be the same - right after the email/name, with no newline.
Any good reasons for the newline?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- You're right—the question mark should be placed immediately after the email/name, so I fixed that.
- The second question is: Do we agree that regardless of whether the email/name is short, long, or too long, the email/name should always be placed on a new line (with the question mark right after the email/name)? This way, all cases will appear as shown in these images. In other words, the length of the email/name won't determine whether it stays on the same line as "Create..." or moves to the next line.
Instead of the previous behavior, where a short name like "admin" remained on the same line, while a long email moved to the next line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix 😄
> | ||
{email} | ||
</strong> | ||
{" "}? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpicking again:
I would've removed the {" "}
, unless there's a good reason.
But that's your decision.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, it looks better without it :)
Closes #8669
Issue
Long user names overflowed "Confirmation" window
Fix
Changes Made
In "Users" Page
The issue screenshot:
The fix screenshot:
Changed in file:
webui/src/pages/auth/users/user/credentials.jsx (getMsg function)
Testing
Verified on lakeFS OSS using local DB & object store & ACL