Clone fix/open-mode-7928 to allow Esti to run #7995
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python's `open` needs a specification of one of create/read/write/append.
otherwise, there will be errors for writes to the SpooledTemporaryFile larger than the buffersize as encoding shall not be set for binary files. The write mode is hardcoded to `wb+` due to an upstream bug.
for files larger than _WRITER_BUFFER_SIZE (hard coded value in /lakefs/object.py, set to 32 MB) Python's SpooledTemporaryFile forces a write to disk. Only then the kwargs passed to it are applied.
which are out of scope for this PR. Namely, reintroducing the write mode depending on user specification once we are no longer affected by the upstream urllib bug and a tuning parameter for the SpooledTemporaryFile size in the tests.
|
Run Esti on #7961 before pulling. |
E2E Test Results - DynamoDB Local - Local Block Adapter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise no secrets.
Do NOT pull