Add esti tests for lakectl local with POSIX permissions #7962
Conversation
itaigilo
added
exclude-changelog
| return LakectlWithParamsWithPosixPerms(accessKeyID, secretAccessKey, endPointURL, false) | ||
| } | ||
|
|
||
| func LakectlWithParamsWithPosixPerms(accessKeyID, secretAccessKey, endPointURL string, withPosixPerms bool) string { |
There was a problem hiding this comment.
Adding this explicitly -
Rather keep this easy to delete (assuming it'll happen in the near future),
Than mess the whole code with changes (of adding a new param).
E2E Test Results - DynamoDB Local - Local Block Adapter |
esti/lakectl_local_test.go
Outdated
| // the following commit "initializes" the posix permissions for the remote repo | ||
| runCmd(t, lakectl+" local commit "+dataDir+" --allow-empty-message -m \" \"", false, false, vars) |
There was a problem hiding this comment.
nit: make it the commit message instead of a comment
| // the following commit "initializes" the posix permissions for the remote repo | |
| runCmd(t, lakectl+" local commit "+dataDir+" --allow-empty-message -m \" \"", false, false, vars) | |
| commitMsg := "initialize the posix permissions for the remote repo" | |
| runCmd(t, lakectl+" local commit "+dataDir+" -m " + commitMsg, false, false, vars) |
There was a problem hiding this comment.
TBH I prefer the fmt.Sprintf way, I noticed it's like that from previous tests as well
There was a problem hiding this comment.
I think that fmt.Sprintf will make this much less readable.
There was a problem hiding this comment.
Anyway, good ideas -
Updated.
|
|
||
| // the following commit "initializes" the posix permissions for the remote repo | ||
| runCmd(t, lakectl+" local commit "+dataDir+" --allow-empty-message -m \" \"", false, false, vars) | ||
|
|
There was a problem hiding this comment.
Maybe add another validation here to check no changes after commit
| @@ -277,7 +277,8 @@ func (s *SyncManager) upload(ctx context.Context, rootPath string, remote *uri.U | |||
| if err := fileutil.VerifySafeFilename(source); err != nil { | |||
| return err | |||
| } | |||
| dest := strings.TrimPrefix(filepath.ToSlash(fmt.Sprintf("%s%s%s", remote.GetPath(), uri.PathSeparator, path)), uri.PathSeparator) | |||
| remotePath := strings.TrimRight(remote.GetPath(), uri.PathSeparator) | |||
There was a problem hiding this comment.
Regarding this change, see this PR.
No description provided.