Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: GetObject check if IfNoneMatch was passed #7543

Merged
merged 3 commits into from
Mar 11, 2024
Merged

Fix: GetObject check if IfNoneMatch was passed #7543

merged 3 commits into from
Mar 11, 2024

Conversation

N-o-Z
Copy link
Member

@N-o-Z N-o-Z commented Mar 10, 2024

Closes #7542

@N-o-Z N-o-Z added bug Something isn't working exclude-changelog PR description should not be included in next release changelog labels Mar 10, 2024
@N-o-Z N-o-Z requested a review from arielshaqed March 10, 2024 14:03
@N-o-Z N-o-Z self-assigned this Mar 10, 2024
@github-actions GitHub Actions
Copy link

E2E Test Results - DynamoDB Local - Local Block Adapter

10 passed

arielshaqed
arielshaqed approved these changes Mar 10, 2024
View reviewed changes
Copy link
Contributor

@arielshaqed arielshaqed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Nice catch, API correctness is always important.

Could some test have caught this?

@N-o-Z
Copy link
Member Author

N-o-Z commented Mar 10, 2024

Thanks! Nice catch, API correctness is always important.

Could some test have caught this?

Added tests

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 10, 2024 •
edited
Loading

♻️ PR Preview e9d7880 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@N-o-Z N-o-Z enabled auto-merge (squash) March 11, 2024 17:17
@N-o-Z N-o-Z merged commit 1c38573 into master Mar 11, 2024
37 checks passed
@N-o-Z N-o-Z deleted the fix/check-empty-etag-get-object-7542 branch March 11, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielshaqed arielshaqed arielshaqed approved these changes

Assignees

@N-o-Z N-o-Z

Labels
bug Something isn't working exclude-changelog PR description should not be included in next release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GetObject might behave strangely if etag / checksum of object is empty
2 participants
@N-o-Z @arielshaqed