Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit and actions msg #124

Merged
merged 5 commits into from
Jun 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .devcontainer/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ ARG NODE_VERSION="lts/*"
RUN if [ "${INSTALL_NODE}" = "true" ]; then su vscode -c "source /usr/local/share/nvm/nvm.sh && nvm install ${NODE_VERSION} 2>&1"; fi
USER vscode
RUN pip3 --disable-pip-version-check --no-cache-dir install -U \
'poetry==1.1.13' \
'poetry==1.8.3' \
'pip==22.1.2'
RUN npm install -g @devcontainers/[email protected]
2 changes: 1 addition & 1 deletion .devcontainer/vm/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ ARG NODE_VERSION="lts/*"
RUN if [ "${INSTALL_NODE}" = "true" ]; then su vscode -c "source /usr/local/share/nvm/nvm.sh && nvm install ${NODE_VERSION} 2>&1"; fi
USER vscode
RUN pip3 --disable-pip-version-check --no-cache-dir install -U \
'poetry==1.1.13' \
'poetry==1.8.3' \
'pip==22.1.2'
RUN npm install -g @devcontainers/[email protected]
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ assignees: ''

---

> [!Note]
> [!Note]
> It may be quicker to check in with us on [Discord](https://discord.gg/QFjCpMjqRY) before logging your issue


Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ assignees: ''

---

> [!Note]
> [!Note]
> It may be quicker to check in with us on [Discord](https://discord.gg/QFjCpMjqRY) before logging your issue

**Is your feature request related to a problem? Please describe.**
Expand Down
15 changes: 14 additions & 1 deletion src/nbmake/pytest_plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
from pathlib import Path
from typing import Any, Optional

from pytest import ExitCode

from .pytest_items import NotebookFile


Expand Down Expand Up @@ -73,4 +75,15 @@ def pytest_terminal_summary(terminalreporter: Any, exitstatus: int, config: Any)
# this message can be disabled with pytest --no-summary
# but let us know if it is annoying you
# ...we can also print diagnostics/stats here -- requests welcome
print(f"\nLearn more about nbmake at https://github.com/treebeardtech/nbmake\n")
try:
if os.environ.get("GITHUB_ACTIONS", False):
if exitstatus == ExitCode.TESTS_FAILED:
print(
f"\n* nbmake: Automate reading GitHub Actions logs with our bot: https://github.com/marketplace/treebeard-build\n"
)
else:
print(
f"\nLearn more about nbmake at https://github.com/treebeardtech/nbmake\n"
)
except:
pass
3 changes: 1 addition & 2 deletions tests/resources/a_test.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@

def test_x():
assert True
assert True
Loading