Add Node.{children_by_field_id,children_by_field_name} #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just making things easier to grep
andreypopp
changed the title
andreypopp
changed the title
andreypopp
force-pushed
the
andreypopp/patch
branch
from
d0bac13
to
9fdb632
Compare
maxbrunsfeld
requested changes
Mar 27, 2021
tree_sitter/binding.c
Outdated
| @@ -134,6 +134,45 @@ static PyObject *node_chield_by_field_name(Node *self, PyObject *args) { | |||
| return node_new_internal(child, self->tree); | |||
| } | |||
|
|
|||
| static PyObject *node_children_by_field_id_internal(Node *self, TSFieldId field_id) { | |||
| PyObject *result = PyList_New(0); | |||
| TSTreeCursor cursor = ts_tree_cursor_new(self->node); | |||
There was a problem hiding this comment.
I think that this TSTreeCursor will be leaked. You would have to destroy it with ts_tree_cursor_delete. But actually, you should probably use the same approach as node_get_children does below, where it reused a global TSTreeCursor called default_cursor (to avoid unnecessary allocations).
There was a problem hiding this comment.
Indeed, updated code to use default_cursor.
| jsx_node = tree.root_node.children[0].children[0] | ||
|
|
||
| attributes = jsx_node.children_by_field_name("attribute") | ||
| self.assertEqual([a.type for a in attributes], ["jsx_attribute", "jsx_attribute"]) |
There was a problem hiding this comment.
These tests are great. Thank you.
andreypopp
force-pushed
the
andreypopp/patch
branch
from
9fdb632
to
e09f2be
Compare
This returns an iterator over multiple nodes for the specified field.
andreypopp
force-pushed
the
andreypopp/patch
branch
from
e09f2be
to
73f6621
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does multiple things but I kept the commits separately so it'd be easier to review. If needed — I can split this into multiple PRs.
What it does:
Node.{children_by_field_id,children_by_field_name}as a convenience for getting a list of nodes by field.