feat: Add iterator methods to Query #207
Open
+415
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add iterator methods to Query
Still need to do
capturesIter
andCapturesIterator
, typings, etc.I'm not that happy about the code duplication though... We could probably implement
matches
andcaptures
in terms ofmatchesIter
andcapturesIter
to reduce it. But that might be slower due to all the additional calls that would entail between C++ and JS, and transferring the nodes one by one.P.S.
LookaheadIterator[@@iterator]
can probably be implemented in C++, andts_query_cursor
can probably be allocated onQuery
instead of inAddonData
if we want too.Fixes #178