-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove warnings #125
base: master
Are you sure you want to change the base?
Remove warnings #125
Conversation
> lib/td/client/api.rb:566: warning: `&' interpreted as argument prefix > lib/td/client/api.rb:673: warning: character class has duplicated range: /[^\-_!~*'()~0-9A-Z_a-z]/ > lib/td/client/api.rb:683: warning: character class has duplicated range: /[^\-_!~*'()~0-9A-Z_a-z]/
2 similar comments
Hmm, build failure on CI relates with SSL version (SSLv3). I guess it's caused by newer OpenSSL version, which just ignore SSLv3 as an invalid version... Is that correct? |
Maybe the libssl is build with NO_SSLv3 option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway could you suppress the error with branching whether the openssl has SSLv3 or not.
Additional to say could you add Ruby 2.6.5 to .travis.yml?
This change is to suppress Ruby runtime warnings. Those are harmful because we may miss really important warnings because of noisy & less-serious warnings.
I saw those from
fluent-plugin-td
test runnings.