Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require numpy minimum version of 1.17.3 #139

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Conversation

tung-vu-td
Copy link
Contributor

@tung-vu-td tung-vu-td commented Sep 17, 2024

Support numpy version from 1.17.3 (for pandas 1.3), and cap below 2.0.0 (pandas supports numpy 2.0 after 2.2.2)

@chezou
Copy link
Member

chezou commented Sep 17, 2024

The error ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject happened when pandas version and numpy version mismatch.
https://stackoverflow.com/a/78641304

Collecting numpy>1.17.3 (from pytd==1.6.0)
Downloading numpy-2.0.2-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (60 kB)

pandas supports numpy 2.0 after 2.2.2 https://pandas.pydata.org/docs/whatsnew/v2.2.2.html#pandas-2-2-2-is-now-compatible-with-numpy-2-0

Tentatively, we can cap numpy to use 1.x.

setup.cfg Outdated Show resolved Hide resolved
Co-authored-by: Aki Ariga <[email protected]>
@chezou
Copy link
Member

chezou commented Sep 18, 2024

In the near future, we may need to release dropping numpy 1.x with pandas 2.2+.

@tung-vu-td tung-vu-td merged commit d5a3aba into master Sep 19, 2024
15 checks passed
@tung-vu-td tung-vu-td deleted the undate-numpy-version branch September 19, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants