-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Python 3.11. Remove support for Python 3.7 #133
Conversation
|
||
[options] | ||
packages = find: | ||
python_requires = >=3.7,<3.11 | ||
python_requires = >=3.7,<3.12 | ||
install_requires = | ||
urllib3~=1.26,>=1.21.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, this urllib3
limitation was introduced many years ago when pip had limited capability to resolve version conflicts. #14
I think we are okay to remove the version constraints, i.e., ~=1.26,>=1.21.1
, (with some manual tests) since pip can resolve to choose the right version of urllib3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @chezou! I created ticket to track this! Kindly continue with the review 🙇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your consideration.
Considering the current pip capability, giving a strict upper version requires frequent release; otherwise, pytd triggers version conflicts too often. Maybe preventing major upgrades for pandas and numpy would be reasonable now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed for data exfiltrations
|
||
[options] | ||
packages = find: | ||
python_requires = >=3.7,<3.11 | ||
python_requires = >=3.7,<3.12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I totally overlooked it, but it should be
python_requires = >=3.8,<3.12
Purpose
We want to add support for python 3.11, while remove support for python 3.7 due to end-of-life status
Overview