Check timeout on acquire #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
From v0.9, AcquiredTask#timeout stores the time when it is acquired. This commit changes the semantics to the last heartbeated time.
* Avoid to touch created_at because it is misused and maybe used in different meanings in the future. From v0.8.48, PQ can use timeout to find living tasks. * Check timeout on heartbeat. v0.9's AcquiredTask#timeout saves the last heartbeated time. PQ can check whether the heartbeating task is still acquired by itself or not.
pass thread execution until monitor thread send heartbeat (or wait while current alive time is available) and sleep for next heartbeat.
To confirm task is alive, wait task_heartbeat in set_task.
I thought timeout's meaning is changed in v0.9, now I can change its type.
nurse
force-pushed
the
check-timeout-on-acquire
branch
from
1070de9 to
8fb4174
Compare
lib/perfectqueue/task_monitor.rb
Outdated
| @@ -145,10 +144,12 @@ def run | |||
|
|
|||
| private | |||
| def task_heartbeat | |||
| @task.heartbeat! | |||
| task = @task | |||
| task.heartbeat! | |||
There was a problem hiding this comment.
Looks like that assigning task is unnecessary.
On prefetch, Processor keeps when it acquires the task.
1 similar comment
|
LGTM!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.