Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove session_state claim condition for end provider session #185

Merged
merged 4 commits into from
Oct 4, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
![Image](https://img.shields.io/docker/pulls/travisghansen/external-auth-server.svg)
![Image](https://img.shields.io/github/workflow/status/travisghansen/external-auth-server/CI?style=flat-square)
![Image](https://img.shields.io/github/actions/workflow/status/travisghansen/external-auth-server/main.yml?branch=master&style=flat-square)

# `external-auth-server`

Expand Down
49 changes: 24 additions & 25 deletions src/plugin/oauth/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -1511,33 +1511,32 @@ class BaseOauthPlugin extends BasePlugin {
sessionPayload.tokenSet.id_token
) {
let idToken = jwt.decode(sessionPayload.tokenSet.id_token);
// TODO: this check may not be entirely needed/wanted
if (idToken.session_state) {
const payload = {
redirect_uri: redirect_uri,
aud: configAudMD5,
req: {
headers: {
referer: req.headers.referer,
},

const payload = {
redirect_uri: redirect_uri,
aud: configAudMD5,
req: {
headers: {
referer: req.headers.referer,
},
request_is_xhr,
};
const stateToken = jwt.sign(payload, issuer_sign_secret);
const state = plugin.server.utils.encrypt(
issuer_encrypt_secret,
stateToken,
"hex"
);
},
request_is_xhr,
};
const stateToken = jwt.sign(payload, issuer_sign_secret);
const state = plugin.server.utils.encrypt(
issuer_encrypt_secret,
stateToken,
"hex"
);

redirect_uri = await client.endSessionUrl({
id_token_hint: sessionPayload.tokenSet.id_token,
post_logout_redirect_uri:
plugin.config.features.logout.end_provider_session
.post_logout_redirect_uri,
state,
});
}
redirect_uri = await client.endSessionUrl({
id_token_hint: sessionPayload.tokenSet.id_token,
post_logout_redirect_uri:
plugin.config.features.logout.end_provider_session
.post_logout_redirect_uri,
state,
});

}

plugin.server.logger.info("deleting session: %s", session_id);
Expand Down