Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Cygwin ICMP service thread for asynchronous pipes #495

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Update Cygwin ICMP service thread for asynchronous pipes #495

merged 1 commit into from
Oct 24, 2023

Commits on Oct 24, 2023

  1. Update Cygwin ICMP service thread for asynchronous pipes 

    Recent versions of Cygwin implement pipe() using Windows' named
pipes, and put the read end of the pipe in FILE_PIPE_COMPLETE_OPERATION
mode, which doesn't allow overlapped I/O operations.

For the relevant commit in the Cygwin repository, see
9e4d308cd592fe383dec58ea6523c1b436888ef8

The solution here is to maintain a Windows event object which is
set only when any ICMP requests are pending.  We can do an alertable
wait on that event object, which will allow us to complete ICMP
requests.

Thanks to Adam Schultz for research into this issue and a first
attempt at a fix.
    @matt-kimball
    matt-kimball committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    dffd81b View commit details
    Browse the repository at this point in the history