Skip to content

Commit

Permalink
Merge pull request #1234 from trapexit/fixes
Browse files Browse the repository at this point in the history
Misc fixes for older platforms
  • Loading branch information
trapexit authored Aug 22, 2023
2 parents 51b65cd + 8d70172 commit 004b616
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
7 changes: 4 additions & 3 deletions src/fs_mktemp.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@

#include <cstdlib>
#include <string>
#include <tuple>

#define PAD_LEN 16
#define MAX_ATTEMPTS 3
Expand Down Expand Up @@ -75,12 +76,12 @@ namespace fs
if((fd == -1) && (errno == EEXIST))
continue;
if(fd == -1)
return {-errno,std::string{}};
return std::make_tuple(-errno,std::string());

return {fd,tmp_filepath};
return std::make_tuple(fd,tmp_filepath);
}

return {-EEXIST,std::string{}};
return std::make_tuple(-EEXIST,std::string());
}

std::tuple<int,std::string>
Expand Down
13 changes: 6 additions & 7 deletions src/gidcache.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,10 @@
#include <unordered_map>
#include <mutex>


#include "gidcache.hpp"

std::mutex g_REGISTERED_CACHES_MUTEX;
std::unordered_map<pid_t,GIDCache*> g_REGISTERED_CACHES;
std::mutex g_REGISTERED_CACHES_MUTEX;
std::unordered_map<pthread_t,GIDCache*> g_REGISTERED_CACHES;


inline
Expand All @@ -55,11 +54,11 @@ GIDCache::GIDCache()
{
std::lock_guard<std::mutex> guard(g_REGISTERED_CACHES_MUTEX);

pid_t tid;
bool inserted;
bool inserted;
pthread_t pthid;

tid = ::gettid();
inserted = g_REGISTERED_CACHES.emplace(tid,this).second;
pthid = pthread_self();
inserted = g_REGISTERED_CACHES.emplace(pthid,this).second;

assert(inserted == true);
}
Expand Down

0 comments on commit 004b616

Please sign in to comment.