Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize pre-commit workflow #215

Merged
merged 7 commits into from
Oct 21, 2024
Merged

Optimize pre-commit workflow #215

merged 7 commits into from
Oct 21, 2024

Conversation

No767
Copy link
Member

@No767 No767 commented Oct 21, 2024

Summary

Caution

This does include breaking changes. You'll need to migrate over to lefthook instead.
Uninstall pre-commit with this: pre-commit uninstall

This PR aims to optimize the pre-commit workflow of Rodhaj. There are some pretty notable changes, including:

  • Migration from pre-commit to Lefthook
  • Changing formatting from Black, Autoflake and Isort to directly using ruff

Types of changes

What types of changes does your code introduce to Rodhaj
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (Updates to README.md, the documentation, etc)
  • Other (if none of the other choices apply)

Checklist

Put an x in the boxes that apply

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes. (if appropriate)
  • All workflows (except pre-commit.ci) pass with my new changes
  • This PR does not address a duplicate issue or PR

Copy link

sonarcloud bot commented Oct 21, 2024

@No767 No767 merged commit 11345f3 into main Oct 21, 2024
3 of 7 checks passed
@No767 No767 deleted the noelle/ruff-fmt branch October 21, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant