Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update transgui.tr #1463

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Update transgui.tr #1463

merged 1 commit into from
Oct 19, 2023

Conversation

sky-khan
Copy link
Contributor

Fixes for Turkish translation

Fixes for Turkish translation
@ghost
Copy link

ghost commented Oct 18, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@what-the-diff
Copy link

what-the-diff bot commented Oct 18, 2023

PR Summary

  • Language Translation Improvements
    The key changes in this pull request are related to improving translations within the application. Each change refers to an adjustment in how specific terms within the application are rendered in a different language (apparently Turkish).

    Important changes include, but are not limited to:

    • "Completed on" is now represented as "Tamamlanma tarihi" in Turkish.
    • The "Donate to support further development" phrase has been translated to "Gelecekteki geliştirmeler için bağışta bulunun".
    • "Enable Peer Exchange" has been translated as "Eş takasını aktif et".
    • "Size to download" has been translated as "İndirilecek boyut".
  • Further Changes
    Most of the file changes listed in this pull request were found to have no actual changes made. Thus, significant changes revolve around language translation improvements only.

Copy link
Member

@PeterDaveHello PeterDaveHello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sky-khan thanks for your contribution, do you know if there's any native speaker can help us verify this change? Really appreciate your help!

@sky-khan
Copy link
Contributor Author

@sky-khan thanks for your contribution, do you know if there's any native speaker can help us verify this change? Really appreciate your help!

I'm a native speaker. I'm Turkish.

@PeterDaveHello
Copy link
Member

@sky-khan yeah I totally understand, just we usually need a reviewer also a native speaker to help confirm 😄

@sky-khan
Copy link
Contributor Author

Well, sorry I'm a lone wolf. I dont know anybody personally who happens to be on github :/

@PeterDaveHello
Copy link
Member

@sky-khan okay, no worries, just please help me double confirm the changes, I'll use Claude-2 and GPT-4 to help me review it 😆

@sky-khan
Copy link
Contributor Author

Sure, how can I help?

@PeterDaveHello
Copy link
Member

@sky-khan nothing but a self review of the pull request / commit 😀 Thanks!

Copy link
Member

@PeterDaveHello PeterDaveHello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by GPT-4 & Claude-2

@PeterDaveHello PeterDaveHello merged commit b1f5c23 into transmission-remote-gui:master Oct 19, 2023
3 of 4 checks passed
@sky-khan
Copy link
Contributor Author

sky-khan commented Oct 19, 2023

Thanks. This was my very first PR and I dont have access to GPT4 so I didnt know what to do exactly :)

@PeterDaveHello
Copy link
Member

@sky-khan oh, I just meant to a self-review from you, that's all ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants