Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight unusually low headways in chart #972

Merged
merged 6 commits into from
Apr 16, 2024
Merged

Conversation

devinmatte
Copy link
Member

@devinmatte devinmatte commented Apr 6, 2024

Motivation

Show headways which are 50% under the benchmark, often meaning that there's bunching

relates to #969

Changes

Screenshot 2024-04-06 at 5 25 30 PM

Screenshot 2024-04-14 at 8 05 56 PM

Testing Instructions

@devinmatte devinmatte marked this pull request as ready for review April 6, 2024 21:35
@github-actions github-actions bot added the frontend Change to frontend code label Apr 6, 2024
Copy link
Member

@nathan-weinberg nathan-weinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this idea, but I almost wonder if we're sending the wrong message here - the blue coloring almost suggests this is a good thing, which on the surface could appear to be the case - such a short wait for a train! - but if we're trying to highlight bunching here, I feel like we should try to more clearly communicate what it is and why it's a bad thing

@devinmatte
Copy link
Member Author

I'm not married to blue as the color, I just didn't want to use a color we already use on the legend

@idreyn
Copy link
Contributor

idreyn commented Apr 13, 2024

I think we should consider repurposing yellow for bunched trips. Then we could do something like this:

image

@devinmatte
Copy link
Member Author

You thinking we shouldn't differentiate 25% late vs 50% late with different colors like we do today and instead just do red for all late trips?

@idreyn
Copy link
Contributor

idreyn commented Apr 13, 2024

Well, I think the system that we have works well, but if we're introducing a color for bunched trips, I think it should be a "warning" color like orange or yellow. My first thought was that we'd no longer be able to use it for slightly late trips, but maybe we could keep it for both?

@idreyn
Copy link
Contributor

idreyn commented Apr 13, 2024

You thinking we shouldn't differentiate 25% late vs 50% late with different colors like we do today and instead just do red for all late trips?

So basically yes, that's the proposal. But I don't feel very strongly about it.

@devinmatte
Copy link
Member Author

devinmatte commented Apr 13, 2024

Perhaps we can call out early trips (25%-) and bunched trips (50%-) with the same colors as 25%+ and 50%+?

@idreyn
Copy link
Contributor

idreyn commented Apr 14, 2024

yes I think that makes the most sense!

@devinmatte
Copy link
Member Author

Screenshot 2024-04-14 at 8 05 56 PM How about this @idreyn?

Copy link
Contributor

@idreyn idreyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@devinmatte devinmatte merged commit 05d72aa into main Apr 16, 2024
4 checks passed
@devinmatte devinmatte deleted the highlight-low-headways branch April 16, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Change to frontend code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants