Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the Mattapan trolley #956

Merged
merged 22 commits into from
Jan 28, 2025
Merged

Adding the Mattapan trolley #956

merged 22 commits into from
Jan 28, 2025

Conversation

devinmatte
Copy link
Member

Motivation

Adds the Mattapan Trolley to the dashboard

We already have the data for it and the performance API supports it

Need to make sure some of the stops are correct, whoever reviews please sanity check stations.json stop maps

Changes

Adds the Mattapan Trolley to the dashboard using Subway presets and a few disabled pages

Testing Instructions

Test on beta, paying attention to weirdness

@github-actions github-actions bot added the frontend Change to frontend code label Mar 10, 2024
@devinmatte devinmatte marked this pull request as ready for review March 10, 2024 22:01
@devinmatte devinmatte added the feature New feature or request label Mar 10, 2024
@rudiejd
Copy link
Contributor

rudiejd commented Mar 28, 2024

all of the frontend stuff lgtm in the beta, I'll wait to approve until we have the data sorted though

@github-actions github-actions bot added the backend Change to backend code label Jan 17, 2025
@devinmatte
Copy link
Member Author

Data is missing for from=70276 and to=70274. All other stop pairs have valid data.

May need to contact the MBTA to figure out why, or dig into LAMP data to figure out if there's a stop id that doesn't exist in the v3 api

@devinmatte
Copy link
Member Author

Missing data is a known issue. Doesn't block releasing, but does require a notice and maybe to disable selecting it in the UI

@devinmatte
Copy link
Member Author

Requires transitmatters/data-ingestion#117 now to merge

@github-actions github-actions bot added the dependencies Changes to dependencies label Jan 26, 2025
Copy link
Contributor

@skaplan-dev skaplan-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick glance at the gtfs for the stop ids but it looks good 👍

@devinmatte devinmatte merged commit d439980 into main Jan 28, 2025
4 checks passed
@devinmatte devinmatte deleted the mattapan-trolley branch January 28, 2025 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Change to backend code dependencies Changes to dependencies feature New feature or request frontend Change to frontend code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants