Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data labels #830

Merged
merged 13 commits into from
Aug 11, 2023
Merged

Fix data labels #830

merged 13 commits into from
Aug 11, 2023

Conversation

PatrickCleary
Copy link
Member

@PatrickCleary PatrickCleary commented Aug 11, 2023

Motivation

I made an oopsie. ChartJS data labels plugin for some reason applies to all charts... Add code to remove that default.

Changes

Fixes bug with chartJS data labels.
Live on https://dashboard-beta.labs.transitmatters.org

Testing Instructions

Look at charts.

@PatrickCleary PatrickCleary self-assigned this Aug 11, 2023
@github-actions github-actions bot added the frontend Change to frontend code label Aug 11, 2023
@PatrickCleary PatrickCleary marked this pull request as ready for review August 11, 2023 21:06
Copy link
Member

@devinmatte devinmatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad plugin 😞

@PatrickCleary PatrickCleary merged commit 2abfb80 into main Aug 11, 2023
5 checks passed
@PatrickCleary PatrickCleary deleted the fix-data-labels branch August 11, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Change to frontend code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants