Adding basic time predictions graph page #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
backend
devinmatte
requested review from
mathcolo,
nathan-weinberg,
austinjpaul,
idreyn,
skaplan-dev and
PatrickCleary
as code owners
|
I plan to add an information section describing the data, but, in the meantime, the rest is ready for review |
|
Is there a way we could default this to one number? I was imagining a series of checkboxes below the graph for each bucket. By default, all are selected and we show the aggregate data. Then if a user wants to see only certain buckets they can select one or more of the buckets. But the graph would always show one line. What do you think? |
|
Yeah I kinda like it. It requires less explanation also I think (still needs some). I'll probably play around with this and see if I like the result |
Screen.Recording.2023-08-15.at.9.57.21.PM.movI like it |
austinjpaul
reviewed
Aug 18, 2023
|
Okay this is now ready for review again 😄 Would love to get any other feedback needed to get this in |
idreyn
approved these changes
Oct 30, 2023
mathcolo
reviewed
Oct 30, 2023
mathcolo
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Show how accurate the MBTA time predictions are over time
Fixes #822
Changes
Testing Instructions