Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v4] hide secrets in healthcheck output #698

Merged
merged 1 commit into from
Jun 24, 2023
Merged

[v4] hide secrets in healthcheck output #698

merged 1 commit into from
Jun 24, 2023

Conversation

mathcolo
Copy link
Contributor

See v3 equivalent for info

@mathcolo mathcolo changed the base branch from main to dashboard-v4 June 23, 2023 17:41
@github-actions github-actions bot added backend Change to backend code ci/cd Affects or Updates CI/CD dependencies Changes to dependencies documentation Improvements or additions to documentation frontend Change to frontend code labels Jun 23, 2023
nathan-weinberg
nathan-weinberg approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member

@nathan-weinberg nathan-weinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call @mathcolo!

@mathcolo mathcolo merged commit b224954 into dashboard-v4 Jun 24, 2023
@mathcolo mathcolo deleted the healthcheck_secrets_v4 branch June 24, 2023 18:44
@devinmatte devinmatte added the v4 label Jul 15, 2023
@devinmatte devinmatte added this to the Dashboard V4 milestone Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathan-weinberg nathan-weinberg nathan-weinberg approved these changes

@austinjpaul austinjpaul Awaiting requested review from austinjpaul

@friendchris friendchris Awaiting requested review from friendchris

@skaplan-dev skaplan-dev Awaiting requested review from skaplan-dev

@devinmatte devinmatte Awaiting requested review from devinmatte

@PatrickCleary PatrickCleary Awaiting requested review from PatrickCleary

Assignees
No one assigned
Labels
backend Change to backend code ci/cd Affects or Updates CI/CD dependencies Changes to dependencies documentation Improvements or additions to documentation frontend Change to frontend code
Projects
Data Dashboard
Archived in project
Milestone
Dashboard V4
Development

Successfully merging this pull request may close these issues.
3 participants
@mathcolo @nathan-weinberg @devinmatte