Adding commuter rail ridership to dashboard #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinmatte
requested review from
mathcolo,
idreyn,
skaplan-dev and
PatrickCleary
as code owners
skaplan-dev
approved these changes
Jul 24, 2024
Comment on lines
+41
to
+50
| const href = React.useMemo(() => { | ||
| switch (line) { | ||
| case 'line-bus': | ||
| return `/bus/trips/single?busRoute=1&date=${BUS_DEFAULTS.singleTripConfig.date}`; | ||
| case 'line-commuter-rail': | ||
| return `/commuter-rail/ridership?crRoute=CR-Lowell&startDate=${COMMUTER_RAIL_DEFAULTS.lineConfig.startDate}&endDate=${COMMUTER_RAIL_DEFAULTS.lineConfig.endDate}`; | ||
| default: | ||
| return getLineSelectionItemHref(line, route); | ||
| } | ||
| }, [line, route]); |
| @@ -20,7 +20,7 @@ export const BetaDataNotice: React.FC = () => { | |||
| const isEndDateAfterBusMaxDay = endDate !== undefined && dayjs(endDate).isAfter(BUS_MAX_DAY); | |||
|
|
|||
| if ( | |||
| (line === 'line-bus' || linePath === 'bus') && | |||
| (line === 'line-commuter-rail' || linePath === 'commuter-rail') && | |||
There was a problem hiding this comment.
do we have these as consts somewhere?
| @@ -21,8 +21,10 @@ export const GobbleDataNotice: React.FC = () => { | |||
| const isEndDateAfterBusMaxDay = endDate !== undefined && dayjs(endDate).isAfter(BUS_MAX_DAY); | |||
|
|
|||
| if ( | |||
| (line === 'line-bus' || linePath === 'bus') && | |||
| (isStartDateAfterBusMaxDay || isEndDateAfterBusMaxDay) | |||
| ((line === 'line-bus' || linePath === 'bus') && | |||
nathan-weinberg
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Subset of #898 that adds ridership to the dashboard
Changes
Testing Instructions
Test in beta today