Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to @ariakit, Modernize RRE #126

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Upgrade to @ariakit, Modernize RRE #126

wants to merge 1 commit into from

Conversation

devinmatte
Copy link
Member

@devinmatte devinmatte commented Dec 15, 2024 •
edited
Loading

Motivation

#122

Changes

  • Updates packages up to a reasonably new state so we can deal with deprecations and fix dangerous code
  • Upgrades Button and Disclosure usage from reakit to @ariakit
  • Upgrade storybook to 7.x, stopping shy of 8.x for now
  • Updates to React 18.x
  • Uses legacy-peer-deps=true for now, with plans to remove after reakit is gone, and nextjs is fully updated

Testing Instructions

@devinmatte devinmatte changed the title Upgrade to @ariakit for Button and Disclosure Upgrade to @ariakit, Modernize RRE Dec 15, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation ci/cd Affects or Updates CI/CD dependencies Pull requests that update a dependency file frontend Change to frontend code labels Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idreyn idreyn Awaiting requested review from idreyn idreyn will be requested when the pull request is marked ready for review idreyn is a code owner

@vickymmcd vickymmcd Awaiting requested review from vickymmcd vickymmcd will be requested when the pull request is marked ready for review vickymmcd is a code owner

@austinjpaul austinjpaul Awaiting requested review from austinjpaul austinjpaul will be requested when the pull request is marked ready for review austinjpaul is a code owner

@mathcolo mathcolo Awaiting requested review from mathcolo mathcolo will be requested when the pull request is marked ready for review mathcolo is a code owner

@nathan-weinberg nathan-weinberg Awaiting requested review from nathan-weinberg nathan-weinberg will be requested when the pull request is marked ready for review nathan-weinberg is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ci/cd Affects or Updates CI/CD dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation frontend Change to frontend code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@devinmatte