Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding Data Dashboard link to Slow Zone posts #25

Merged
merged 5 commits into from
Aug 19, 2023

Conversation

nathan-weinberg
Copy link
Member

@nathan-weinberg nathan-weinberg commented May 16, 2023

Fixes #15

@skaplan-dev I was able to kinda test this by putting the function somewhere unconventional and doing a dry run of the bot, but curious if you have a way to test this stuff so I could visualize how it looks?

@devinmatte not sure if there's anyway to future-proof this for V4, but if so feel free to advise 👍

@github-actions github-actions bot added the backend Change to backend code label May 16, 2023
@nathan-weinberg nathan-weinberg force-pushed the dash-link branch 7 times, most recently from 2c4d8e5 to 1426e7a Compare May 17, 2023 00:30
@github-actions github-actions bot added the ci/cd Affects or Updates CI/CD label May 17, 2023
@skaplan-dev
Copy link
Collaborator

skaplan-dev commented May 17, 2023

Fixes #15

@skaplan-dev I was able to kinda test this by putting the function somewhere unconventional and doing a dry run of the bot, but curious if you have a way to test this stuff so I could visualize how it looks?

@devinmatte not sure if there's anyway to future-proof this for V4, but if so feel free to advise 👍

no super great way to test this besides just printing things out locally. it might be worth us building a test Twitter bot for stuff like this. I'd actually prefer if we tweeted the dashboard link as a response to the tweet (open to debating this). We don't have great twitter meta tags that add nice visualizations for dashboard links.

@devinmatte
Copy link
Member

v3 links will translate to v4 on launch. After launch we can update this bot to point to newer link formats

utils.py Outdated Show resolved Hide resolved
@nathan-weinberg
Copy link
Member Author

Fixes #15
@skaplan-dev I was able to kinda test this by putting the function somewhere unconventional and doing a dry run of the bot, but curious if you have a way to test this stuff so I could visualize how it looks?
@devinmatte not sure if there's anyway to future-proof this for V4, but if so feel free to advise +1

no super great way to test this besides just printing things out locally. it might be worth us building a test Twitter bot for stuff like this. I'd actually prefer if we tweeted the dashboard link as a response to the tweet (open to debating this). We don't have great twitter meta tags that add nice visualizations for dashboard links.

I'd def be open to that idea - I think visually it'd be more appealing - we might need to play with the bot logic since the reply scheme would work differently for Mastodon/Slack.

Another thing I was looking into was URL shorteners for the Dashboard links so they might look a bit better as part of the main tweet - we would probably need to sign up for a service like Bitly for that, the only native Python library I could find for that seems abandoned.

@nathan-weinberg nathan-weinberg force-pushed the dash-link branch 2 times, most recently from a106a1b to 14761ba Compare June 7, 2023 01:07
@devinmatte
Copy link
Member

We should update this now with v4 links

utils.py Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the ci/cd Affects or Updates CI/CD label Aug 17, 2023
@nathan-weinberg nathan-weinberg changed the title Adding Data Dashboard link to Slow Zone posts feat: Adding Data Dashboard link to Slow Zone posts Aug 17, 2023
made some stylistic changes to variable and function naming
to try and make things a bit more consistent across the bot
Copy link
Member

@devinmatte devinmatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe wait on @skaplan-dev to make sure we're ready to launch this

@nathan-weinberg
Copy link
Member Author

I tried to test this with the test Twitter bot but was unable to do so - would someone who configured the Prod bot be able to adjust the settings to allow for write access? Can share the keys via Slack if needed

@nathan-weinberg
Copy link
Member Author

Ofc we can always merge this and hope for the best 😄

@nathan-weinberg nathan-weinberg merged commit 6d2ccd3 into transitmatters:main Aug 19, 2023
5 checks passed
@nathan-weinberg nathan-weinberg deleted the dash-link branch August 19, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Change to backend code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add link to Data Dashboard in Slow Zone tweet
3 participants