-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding Data Dashboard link to Slow Zone posts #25
feat: Adding Data Dashboard link to Slow Zone posts #25
Conversation
2c4d8e5
to
1426e7a
Compare
no super great way to test this besides just printing things out locally. it might be worth us building a |
v3 links will translate to v4 on launch. After launch we can update this bot to point to newer link formats |
I'd def be open to that idea - I think visually it'd be more appealing - we might need to play with the bot logic since the reply scheme would work differently for Mastodon/Slack. Another thing I was looking into was URL shorteners for the Dashboard links so they might look a bit better as part of the main tweet - we would probably need to sign up for a service like Bitly for that, the only native Python library I could find for that seems abandoned. |
a106a1b
to
14761ba
Compare
We should update this now with v4 links |
2901ee7
to
0bc462d
Compare
020a486
to
2832426
Compare
made some stylistic changes to variable and function naming to try and make things a bit more consistent across the bot
2832426
to
80c176f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Maybe wait on @skaplan-dev to make sure we're ready to launch this
I tried to test this with the test Twitter bot but was unable to do so - would someone who configured the Prod bot be able to adjust the settings to allow for write access? Can share the keys via Slack if needed |
Ofc we can always merge this and hope for the best 😄 |
Fixes #15
@skaplan-dev I was able to kinda test this by putting the function somewhere unconventional and doing a dry run of the bot, but curious if you have a way to test this stuff so I could visualize how it looks?
@devinmatte not sure if there's anyway to future-proof this for V4, but if so feel free to advise 👍