Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CalVer #716

Merged
merged 21 commits into from
Jan 14, 2025
Merged

Support CalVer #716

merged 21 commits into from
Jan 14, 2025

Conversation

kitallis
Copy link
Member

@kitallis kitallis commented Jan 8, 2025

Closes: #584

We'll do CalVer in the following format:

yyyy.0m.0d{0seq-number}-{suffix}
2025.01.02
2025.01.0201
2025.01.0202
2025.01.0203-staging
etc.

Currently decided rules for bumping:

  • Major / minor don't bump anything
  • Major / minor only bump if calendar changes
  • Patch only bumps sequence number, doesn't change the day

BNF grammar for CalVer:

<version> ::= <year> "." <month> "." <day-seq> ["-" <suffix>]

<year>    ::= <digit4>
<month>   ::= <digit2>
<day-seq> ::= <day> [<seq-number>]
<day>     ::= <digit2>

<digit4>  ::= <digit> <digit> <digit> <digit>
<digit2>  ::= <digit> <digit>
<digit>   ::= "0" | "1" | "2" | "3" | "4" | "5" | "6" | "7" | "8" | "9"

<seq-number> ::= <digit2>

<suffix>  ::= <alphanum> {<alphanum> | "-"}*
<alphanum> ::= <letter> | <digit>
<letter>  ::= "A" | "B" | "C" | ... | "Z" | "a" | "b" | "c" | ... | "z"

; Additional constraints:
; - <month> must be between "01" and "12"
; - <day> must be between "01" and "31" (depending on month)
; - <seq-number> is optional and starts from "01"

TODO:

  • Validity check for when we use a Custom Version in SemVer
  • Test for hotfixes
  • Test across cross-platform apps (and version drift between them)
  • Change the static text in the train form about SemVer-like
  • Starting more than 1 successful production release on the same day

@kitallis kitallis marked this pull request as ready for review January 13, 2025 13:53
Copy link
Member

@nid90 nid90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟 lgtm

@kitallis kitallis merged commit 2d386b9 into main Jan 14, 2025
4 checks passed
@kitallis kitallis deleted the feat/calver branch January 14, 2025 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants