Reuse integrations from across apps #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gitstart-app[bot]](https://avatars.githubusercontent.com/in/46283?s=60&v=4){kind=small}
Contributor
gitstart-app
bot
commented
Jan 3, 2025
•
gitstart-app
bot
commented
- Merge reuse across apps and within a single app
- If there is more than one option to re-use (relies on metadata to find unique), a modal will open to choose
- Duplicate provider (providable) record on re-use, sharing providers across apps will not work since the provider classes rely on single app relationship
|
Hi @kitallis, PR is ready for review. |
kitallis
requested changes
Jan 6, 2025
app/models/integration.rb
Outdated
| @@ -201,6 +201,11 @@ def existing_integration(app, providable_type) | |||
| app.integrations.connected.find_by(providable_type: providable_type) | |||
| end | |||
|
|
|||
| # This method retrieves a list of existing integrations for apps within the same organization | |||
| def existing_integrations_across_app(app, providable_type) | |||
| Integration.connected.where(integrable_id: app.organization.apps.where.not(id: app.id), providable_type: providable_type).select("DISTINCT ON (providable_id, integrable_id) id, providable_id, integrable_id, providable_type, created_at, updated_at, metadata, integrable_type") | |||
There was a problem hiding this comment.
suggestion: let's change the DISTINCT ON to do DISTINCT ON (providable_id, integrable_id) id, * so we don't have to keep this query updated as new columns are added.
| @@ -17,6 +18,18 @@ def index | |||
| set_integrations_by_categories | |||
| end | |||
|
|
|||
| # This method handles the process of reusing an existing app integration to create a new one | |||
| # Attempts to create a new integration based on the existing one across app | |||
| def reuse_integration_across_app | |||
There was a problem hiding this comment.
suggestion: I think we can use the reuse action here, afaict, they do the same thing; we don't need a separate route for it.
There was a problem hiding this comment.
Sure. We will make the changes and get back to you.
|
Hi @kitallis, requested changes have been addressed. Please review |
kitallis
reviewed
Jan 20, 2025
app/helpers/application_helper.rb
Outdated
| @@ -57,6 +57,11 @@ def toggle_for(hide, full_width: false, &block) | |||
| ) | |||
| end | |||
|
|
|||
| # Displays label which combines the app's bundle identifier, type, and ID | |||
kitallis
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.