Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate all ActiveJobs to Sidekiq jobs #699

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Migrate all ActiveJobs to Sidekiq jobs #699

wants to merge 3 commits into from

Conversation

gitstart-app[bot]
Copy link
Contributor

@gitstart-app gitstart-app bot commented Dec 18, 2024 •
edited
Loading

What this PR achieves?

  • Migrating from ActiveJob to Sidekiq::Job
  • Changing the call-sites to be perform_async rather than perform_later
  • Fixing failing tests after the migration

Screenshot

All the tests are passing after the change

@gitstart-tramline
Copy link

Hi @kitallis, PR is ready for review.

kitallis
kitallis reviewed Dec 26, 2024
View reviewed changes
Copy link
Member

@kitallis kitallis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we first get this updated with the latest main?
It'll be easier to review since there's a lot of code that has been deleted.

@gitstart-tramline
Copy link

Could we first get this updated with the latest main? It'll be easier to review since there's a lot of code that has been deleted.

Sure, we will resolve the conflicts and update the PR

@gitstart-tramline
Copy link

Hi @kitallis,
We have resolved the conflicts, please review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitallis kitallis kitallis left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gitstart-tramline @kitallis