Add initial sync #319
Open
Add initial sync #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I actually noticed a bug with the logic to retry requests after 429 status, will fix and add commits here. |
Let me know when it is ready for review.... |
jerone
reviewed
Mar 16, 2024
| "message": "Sync full history?" | ||
| }, | ||
| "initialSyncDescription": { | ||
| "message": "This is the first time that you are accessing this service. Would you like to sync the full history right now? This may take a while depending on how big your history is.\n\nBefore choosing \"Yes\", make sure that the options below are adjusted to your liking.\n\nIf you choose \"No\", you will not be asked this again, unless you clear the last sync date for the service or clear the storage." |
There was a problem hiding this comment.
Suggested change
| "message": "This is the first time that you are accessing this service. Would you like to sync the full history right now? This may take a while depending on how big your history is.\n\nBefore choosing \"Yes\", make sure that the options below are adjusted to your liking.\n\nIf you choose \"No\", you will not be asked this again, unless you clear the last sync date for the service or clear the storage." | |
| "message": "This is the first time that you are accessing this service. Would you like to sync the full history right now? This may take a while depending on how big your history is.\n\nBefore choosing \"Yes\", make sure that the options below are adjusted to your liking.\n\nIf you choose \"No\", you will not be asked this again, unless you clear the last sync date for the service or clear the storage. You can always trigger the sync manually." |
Makes it less of a now-or-never condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47
I tested on Netflix and HBO Max and it seems to work well.