Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply faster implementation of word throughout #220

Merged
merged 2 commits into from
May 1, 2024
Merged

Apply faster implementation of word throughout #220

merged 2 commits into from
May 1, 2024

Conversation

dfalster
Copy link
Member

@dfalster dfalster commented May 1, 2024

As part of #196, we found that string::word was quite slow, and so implemented a faster version. This PR

  • makes the new word function a private function, accessible via APCalign:::word
  • adds tests for new function
  • extends use of this new function throughout

@dfalster dfalster requested a review from ehwenk May 1, 2024 08:37
ehwenk
ehwenk approved these changes May 1, 2024
View reviewed changes
Copy link
Collaborator

@ehwenk ehwenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the code for the actual word function identical to what had been in load_taxonomic_resources - hard to look through line by line.

@dfalster
Copy link
Member Author

dfalster commented May 1, 2024

Yes, same function! But I added the argument 'sep'

@dfalster dfalster merged commit 9be9776 into develop May 1, 2024
4 checks passed
@dfalster dfalster deleted the faster_word branch May 1, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehwenk ehwenk ehwenk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dfalster @ehwenk