simplfying data download and adding a trycatch #169
Conversation
For APC taxa, the scientific_name_id was the scientific_name_id for the aligned name, not the accepted_name. This was because scientific_name_id was merged in too early - it has been fixed.
* map in APNI genera We'd initially made the decision that the genus-column would remain blank if the genus wasn't APC-accepted. For AusTraits at least this is odd - as there are 100's of entries with a taxon name, scientific name, scientific name identifier, but no genus.
Fix how a "genus" is identified within a taxon name - For hybrid genera the genus name is "x genus" - this was causing problems in AusTraits, because I'd only included an ifelse to hunt for "x" in some places - As part of this fix, package `extract_genus` into its own function
There was a problem hiding this comment.
Is removing contentid completely a good move? @wcornwell @dfalster? I think this is a good intermediate solution to stay on CRAN until we figure out contentid properly. thoughts?
|
until the data is in more than one place, I don't think contentID functionality makes sense? Once APC has a canonical place also, then we can revisit? Do you want to merge some of your changes in @fontikar ? |
|
I agree with Will! |
@wcornwell can I change the merging base into |
|
@fontikar do whatever makes sense to you! many options |
* Added trigger for R CMD check for develop * simplfying data download and adding a trycatch, removing contentid for the short term and simplifying data download (#169) --------- Co-authored-by: Elizabeth Wenk <[email protected]> Co-authored-by: Fonti Kar <[email protected]> * Graceful testing for load_taxonomic_resources (#164) * Added dummy variable to test if network connection is down * Refined testing for no network * Bumped version and news --------- Co-authored-by: Will Cornwell <[email protected]> Co-authored-by: Elizabeth Wenk <[email protected]>
* simplfying data download and adding a trycatch (#169) removing contentid for the short term and simplifying data download. * Graceful testing for load_taxonomic_resources (#164) * Add GitHub links to DESCRIPTION * Updated hex #81 * NEWS updates and CRAN comments, Reverse dependency comments * Updated documentation for create_taxonomic_update_lookup #168 * Minor updates to documentation for resources argument * Minor documentation changes --------- Co-authored-by: Will Cornwell <[email protected]> Co-authored-by: Elizabeth Wenk <[email protected]> Co-authored-by: Fonti Kar <[email protected]>
Simplifying data download to make server errors less likely, and adding a trycatch for the download step.