Add exclusion patterns for curl-unecrypted-url #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruechel-canva
requested review from
GrosQuildu and
mschwager
as code owners
|
|
GrosQuildu
previously approved these changes
Dec 13, 2024
|
LGTM - the one suggestion I have is that we add the AWS IPv6 metadata address too: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/instancedata-data-retrieval.html#instancedata-inside-access |
|
Hey @fruechel-canva, are you still interested in this PR? |
|
Hi @mschwager, sorry for the delay. I had to get approval from legal for the CLA and then went on a holiday break. I've signed the CLA and added the IPv6 address like you proposed. Let me know if you need anything else! |
mschwager
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
No worries @fruechel-canva! Thanks for the improvements here, we appreciate it!
curl-unecrypted-url produces a lot of false positives on repositories with lots of cloud infrastructure code for AWS or GCP. These providers use link local URLs via HTTP without TLS. This is equivalent to localhost patterns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
curl-unecrypted-urlproduces a lot of false positives on repositories with lots of cloud infrastructure code for AWS or GCP. These providers use link local URLs via HTTP without TLS. This is equivalent to localhost patterns.