Skip to content

Commit

Permalink
fix tests
Browse files Browse the repository at this point in the history
  • Loading branch information
trafficonese committed Apr 13, 2022
1 parent 02de836 commit 8f11388
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 30 deletions.
10 changes: 5 additions & 5 deletions R/daterangepicker.R
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@
#' @family perioddaterangepicker Functions
#' @export
updatePerioddaterangepicker <- function(session, inputId, label = NULL,
start = NULL, end = NULL,
min = NULL, max = NULL,
icon = NULL, options = NULL,
ranges = NULL, style = NULL,
class = NULL) {
start = NULL, end = NULL,
min = NULL, max = NULL,
icon = NULL, options = NULL,
ranges = NULL, style = NULL,
class = NULL) {

## If no icon was passed initially, we need to create a WebDependency-list
## On the JS-side `Shiny.renderDependencies` adds the deps to the header
Expand Down
50 changes: 25 additions & 25 deletions tests/testthat/test-daterangepicker.R
Original file line number Diff line number Diff line change
Expand Up @@ -142,31 +142,31 @@ test_that("perioddaterangepicker", {
expect_length(object = htmltools::findDependencies(x), n = 1)

## Updates #########################
# session <- as.environment(list(
# ns = identity,
# sendInputMessage = function(inputId, message) {
# session$lastInputMessage = list(id = inputId, message = message)
# }
# ))

# updateDaterangepicker(session, "daterange", label = "NewLabel",
# start = start, end = end)
# res <- session$lastInputMessage
# expect_identical(res$message$id, "daterange")
# expect_identical(res$message$label, "NewLabel")
# expect_identical(res$message$start, start)
# expect_identical(res$message$end, end)
#
# updateDaterangepicker(session, "daterange", label = "NewLabel",
# start = start, end = end, icon = icon("calendar"))
# res <- invisible(session$lastInputMessage)
# expect_identical(res$message$id, "daterange")
# expect_identical(res$message$label, "NewLabel")
# expect_identical(res$message$start, start)
# expect_identical(res$message$end, end)
# expect_is(res$message$icon, "shiny.tag")
# expect_is(res$message$icon$htmldeps[[1]], "html_dependency")
# expect_length(res$message$icon$htmldeps[[1]], 9)
session <- as.environment(list(
ns = identity,
sendInputMessage = function(inputId, message) {
session$lastInputMessage = list(id = inputId, message = message)
}
))

updatePerioddaterangepicker(session, "daterange", label = "NewLabel",
start = start, end = end)
res <- session$lastInputMessage
expect_identical(res$message$id, "daterange")
expect_identical(res$message$label, "NewLabel")
expect_identical(res$message$start, start)
expect_identical(res$message$end, end)

updatePerioddaterangepicker(session, "daterange", label = "NewLabel",
start = start, end = end, icon = icon("calendar"))
res <- invisible(session$lastInputMessage)
expect_identical(res$message$id, "daterange")
expect_identical(res$message$label, "NewLabel")
expect_identical(res$message$start, start)
expect_identical(res$message$end, end)
expect_is(res$message$icon, "shiny.tag")
expect_is(res$message$icon$htmldeps[[1]], "html_dependency")
expect_length(res$message$icon$htmldeps[[1]], 9)

## onLoad #######################
expect_null(perioddaterangepicker:::.onLoad()(NULL))
Expand Down

0 comments on commit 8f11388

Please sign in to comment.