Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to produce array of results for blocks #1081

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add option to produce array of results for blocks #1081

wants to merge 1 commit into from

Conversation

firelizzard18
Copy link
Contributor

This PR adds an option, interp.Options.BlockStatementAsArray, which configures the interpreter to return an array of results for each statement of a block, instead of just the last statement.

@mvertes
Copy link
Member

mvertes commented Apr 14, 2021

Thank you for your proposal, but please, wait a little so we can settle the previous ones. It's not a go yet for #1078 and #1079, we need a bit of a design review first before jumping on coding, and I still have concerns. I will provide more details soon.

@firelizzard18
Copy link
Contributor Author

FWIW, all three PRs are independent features. They don't build on each other.

@firelizzard18 firelizzard18 mentioned this pull request Apr 16, 2021
Closed
@firelizzard18 firelizzard18 marked this pull request as draft August 6, 2021 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/core enhancement New feature or request status/1-needs-design-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@firelizzard18 @mvertes