Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Chart)!: 📦 add separated chart for CRDs #1223

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

feat(Chart)!: 📦 add separated chart for CRDs #1223

wants to merge 27 commits into from

Conversation

darkweaver87
Copy link
Contributor

@darkweaver87 darkweaver87 commented Oct 14, 2024 •
edited
Loading

What does this PR do?

This PR introduces a separate chart used by the main one to install CRDs.
The dependency between the main chart and the CRDs one will be added once CRDs one will be released.

Motivation

#1141
#1209

More

  • Yes, I updated the tests accordingly
  • Yes, I updated the schema accordingly
  • Yes, I ran make test and all the tests passed

@darkweaver87 darkweaver87 added kind/enhancement New feature or request kind/proposal a proposal that needs to be discussed. labels Oct 14, 2024
@darkweaver87 darkweaver87 force-pushed the feat/crds branch 2 times, most recently from bd35651 to b674cf7 Compare October 14, 2024 08:39
@darkweaver87 darkweaver87 changed the title feat: 📦 add separated chart for CRDs feat!: 📦 add separated chart for CRDs Oct 14, 2024
mloiseleur
mloiseleur reviewed Oct 14, 2024
View reviewed changes
traefik/values.yaml Outdated Show resolved Hide resolved
@darkweaver87 darkweaver87 force-pushed the feat/crds branch 9 times, most recently from 9087b4b to e1eb8a0 Compare October 14, 2024 14:53
@darkweaver87 darkweaver87 mentioned this pull request Oct 15, 2024
Merged
3 tasks
@mloiseleur mloiseleur linked an issue Oct 16, 2024 that may be closed by this pull request
CRD only Helm chart for Traefik #1141
Open
2 tasks
@rgdev rgdev mentioned this pull request Oct 17, 2024
Open
mloiseleur
mloiseleur requested changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@mloiseleur mloiseleur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The CI needs to be tested, with a tag on your fork.
  2. The documented CRDs upgrade process should still work. I see (at least) two options:
    a. Keep and copy crd files
    b. Update CRD upgrade instruction to use them in the new directory

@darkweaver87 darkweaver87 force-pushed the feat/crds branch 2 times, most recently from e9619df to 6a67459 Compare October 21, 2024 06:50
@darkweaver87
Copy link
Contributor Author

darkweaver87 commented Oct 21, 2024 •
edited
Loading

Tested on my own account as seen with you 👍

darkweaver87 and others added 24 commits November 4, 2024 08:17
@darkweaver87
feat: 📦 add separated chart for CRDs
3ae8643
@darkweaver87
fix: schemas
7cbb1d2
@darkweaver87
fix: use Files.Glob
542caf9
@darkweaver87
fix: CI
7e47853
@darkweaver87
fix: update CI
39cafb7
@darkweaver87
fix: add hub only when api management is enabled
6bee6b0
@darkweaver87
fix: CI
f133139
@darkweaver87
fix: snapshot dir
be0c406
@darkweaver87
fix: remove dependency while not published
e2c4a61
@darkweaver87 @mloiseleur
fix: apply suggestions from @mloiseleur's code review
2ec4326 
Co-authored-by: Michel Loiseleur <[email protected]>
@darkweaver87
fix: tag exist condition
c5ccab3
@darkweaver87
fix: charts_dir
305295b
@darkweaver87
fix: changelog
8c5d274
@darkweaver87
fix: get chart version
80209bf
@darkweaver87
fix: reduce changelog on patches
c92993e
@darkweaver87
fix: ci workflow to handle two different releases
cc23a43
@darkweaver87
fix: Chart.yaml
f77f38f
@darkweaver87
fix: more reliable changelog.sh
e5104ec
@darkweaver87 @mloiseleur
fix: apply suggestions from @mloiseleur's code review
6c8a6ab 
Co-authored-by: Michel Loiseleur <[email protected]>
@darkweaver87
fix: preserve CRDs by default
cface26
@darkweaver87
fix: add some annotations on CRDs
a8ba0b8
@darkweaver87
fix: schemas and helper
b132409
@darkweaver87
fix: doc
e62e239
@darkweaver87
fix: CI
70e50e4
@mloiseleur mloiseleur changed the title feat!: 📦 add separated chart for CRDs feat(Chart)!: 📦 add separated chart for CRDs Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mloiseleur mloiseleur Awaiting requested review from mloiseleur

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
bot/no-merge kind/enhancement New feature or request kind/proposal a proposal that needs to be discussed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don’t bundle Gateway API CRDs CRD only Helm chart for Traefik
3 participants
@darkweaver87 @mloiseleur @jnoordsij