-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: custom date picker #456
Merged
traefiker
merged 18 commits into
traefik:master
from
mdeliatf:feat/remove-react-datepicker
Nov 6, 2024
Merged
feat!: custom date picker #456
traefiker
merged 18 commits into
traefik:master
from
mdeliatf:feat/remove-react-datepicker
Nov 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdeliatf
added
enhancement
New feature or request
status/2-needs-review
00-type/task
labels
Nov 4, 2024
mdeliatf
force-pushed
the
feat/remove-react-datepicker
branch
from
November 4, 2024 08:55
3b3080e
to
233d1bf
Compare
gndz07
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎉 This PR is included in version 11.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces react-datepicker with a custom component built on top of @rehookify/datepicker.
This modification will enable full customization of the date-time picker and resolve an issue that Vite encounters with
.css
files in thenode_modules
folder.Preview
Dependency changes
Breaking changes
Different date-time picker component.
Good PR checkboxes
Good Review checkboxes
ℹ️ Copy the snippet and paste in the review field to fill it