feat: add order of the JWT source header/cookie/query as config #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonpahl
force-pushed
the
jwtSourcePrirority
branch
2 times, most recently
from
0698236 to
0bfb9ae
Compare
eshepelyuk
reviewed
Jun 28, 2024
There was a problem hiding this comment.
- First issue is missing unit tests.
- Second I'd like propose a deeper change, instead of having several parameters to configure order and source of token extraction - i think about boling it down to one parameter that could look like
JwtSources:
- bearer:MyAuth # value from http header in format Bearer: TOKEN
- header:MyJwt # plain value of http header
- cookie:MyCookie # plain value of cookie
- query:MyQuery # plain value of query string parameterWDYT ?
simonpahl
force-pushed
the
jwtSourcePrirority
branch
from
0bfb9ae to
72addc1
Compare
|
I like the idea and i am working on it. I've pushed my progress so far. One problem is preserving the order, als pure maps can't do that. The current idea for the config is |
simonpahl
force-pushed
the
jwtSourcePrirority
branch
2 times, most recently
from
42dc5c9 to
ed7fc6d
Compare
|
Ok, i think it is done. |
eshepelyuk
requested changes
Jun 29, 2024
simonpahl
force-pushed
the
jwtSourcePrirority
branch
from
ed7fc6d to
339b7af
Compare
The config field is called JwtSources,
the format is [{type: ...., key: ...},]
Possible types are bearer, header, cookie, query.
The order of the list enty is the order in wich the JWT wil be tried to
retrieved.
simonpahl
force-pushed
the
jwtSourcePrirority
branch
from
339b7af to
cbc7555
Compare
|
understood, thanks |
eshepelyuk
approved these changes
Jun 29, 2024
|
Thanks for anither great contributions, availablein 0.9.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR it is posible to control the order how the JWT is resolved from header, cookie or query parameter.