Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gd/update positions/155955097 #93

Merged
merged 2 commits into from
Mar 20, 2018
Merged

Gd/update positions/155955097 #93

merged 2 commits into from
Mar 20, 2018

Conversation

guillaumedebavelaere
Copy link
Contributor

No description provided.

jsom
jsom reviewed Mar 19, 2018
View reviewed changes
Copy link
Contributor

@jsom jsom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add the deprecation notices for the dollar values here as well?

If I am an AndroidSDK developer will I see deprecation warnings coming from the JavaAPI even if I don't use the Android SDK *Dollar fields any more?

@guillaumedebavelaere
Copy link
Contributor Author

@jsom as it extends the TradeItPosition, the dollars fields will be deprecated as well for the TradeItPositionParcelable

@mitochondrion
Copy link
Contributor

@guillaumedebavelaere Looks good to me other than what James mentioned about deprecation.

@guillaumedebavelaere guillaumedebavelaere merged commit 3e55ff4 into develop Mar 20, 2018
@guillaumedebavelaere guillaumedebavelaere deleted the gd/update_positions/155955097 branch March 20, 2018 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsom jsom jsom left review comments

@mitochondrion mitochondrion Awaiting requested review from mitochondrion

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guillaumedebavelaere @mitochondrion @jsom