Add warnings and deprecate ackWarningsList and warningsList #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsom
force-pushed
the
jrs/#155954025/add-new-warnings
branch
from
6f073ac to
c06416d
Compare
jsom
commented
Mar 14, 2018
| import it.trade.model.reponse.Warning; | ||
|
|
||
| public class TradeItOrderDetailsParcelable implements Parcelable { | ||
| public String orderSymbol; |
There was a problem hiding this comment.
@guillaumedebavelaere I updated to move warnings to the orderDetails. What's our strategy for accessors? Half the classes seem to define them for other fields but then others don't and just mark the field as public.
There was a problem hiding this comment.
If the user is supposed to modify these fields you can let them public. Otherwise, you can mark them private (or package-private/protected if you need to set them in unit tests) and add a getter.
jsom
force-pushed
the
jrs/#155954025/add-new-warnings
branch
from
c06416d to
5a7309b
Compare
|
@guillaumedebavelaere updated with |
| import it.trade.model.reponse.WarningLink; | ||
|
|
||
| public class TradeItWarningLinkParcelable implements Parcelable { | ||
| protected String label; |
There was a problem hiding this comment.
Can you add the getters?
| import it.trade.model.reponse.WarningLink; | ||
|
|
||
| public class TradeItWarningParcelable implements Parcelable { | ||
| protected String message; |
There was a problem hiding this comment.
Can you add the getters?
jsom
force-pushed
the
jrs/#155954025/add-new-warnings
branch
from
5a7309b to
b5a1d1d
Compare
guillaumedebavelaere
approved these changes
Mar 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.