Accept strings for action, priceType and expiration #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No, you can rip out the enums.
You can update the wiki to add the use of the capabilities. There are also some unit tests you can run. |
|
@guillaumedebavelaere updated with unit tests passing |
guillaumedebavelaere
approved these changes
Mar 6, 2018
| order.setLimitPrice(20.0); | ||
| order.setExpiration(TradeItOrderExpiration.GOOD_FOR_DAY); | ||
| order.setPriceType(TradeItOrderPriceType.LIMIT); | ||
| order.setExpiration(equityCapabilities.getActions().get(0).getValue()); |
There was a problem hiding this comment.
Looks like you forgot to set an action...
jsom
force-pushed
the
jrs/use-order-caps-for-order
branch
from
8691f53 to
806014e
Compare
… and expiration type
jsom
force-pushed
the
jrs/use-order-caps-for-order
branch
from
806014e to
d58bd9c
Compare
jsom
commented
Mar 6, 2018
| public enum TradeItOrderAction { | ||
| BUY("buy"), | ||
| SELL("sell"), | ||
| BUY_TO_COVER("buyTocover"), | ||
| BUY_TO_COVER("buyToCover"), |
There was a problem hiding this comment.
This seems like it was a typo in the value?
|
@guillaumedebavelaere I'll update the wiki when this gets merged. |
guillaumedebavelaere
approved these changes
Mar 7, 2018
| public enum TradeItOrderAction { | ||
| BUY("buy"), | ||
| SELL("sell"), | ||
| BUY_TO_COVER("buyTocover"), | ||
| BUY_TO_COVER("buyToCover"), |
guillaumedebavelaere
approved these changes
Mar 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partners should be using the order capabilities to set
action,priceTypeandexpirationfor an order object as part of the FV1 migration.TODO:
Hurr. I Android developer now.