Gd/sdk supports crypto/160078379

[guillaumedebavelaere]

No description provided.

[gigiyy]

I added some comments.

[gigiyy]

maybe better to extract these to a getCrytoAccunt function instead?

[gigiyy]

finding the crypto account and be simplified to as below:

val cryptoAccount = linkedBrokers.mapNotNull { linkedBroker -> linkedBroker.accounts.find{
      it.getOrderCapabilityForInstrument(Instrument.CRYPTO) != null
}}.firstOrNull()

[gigiyy]

maybe no need to transform it to use functional calls, however, maybe it's better to extracted to a functional call too, like in java example app.

[gigiyy]

when is expression in kotlin, you can return the when result direclty:

return when(xxx){
    aaa -> bbb
    ccc -> ddd
    else null
}

[mitochondrion]

Should this be private? It seems like it's only used so that the constructor can take a raw string. Or should we have some kind of SymbolPair object so that our expectation from consumers of this library is explicit? That way there is no guessing what format of crypto pair we accept from the UI.

[mitochondrion]

This should be a guard-style statement so that the corresponding else block isn't so large. Something like:

if (linkedBrokers.isEmpty()) {
    showAlert("previewTradeFirstLinkedBroker", "No linked broker!");
    return;
}

// Then you don't need the else clause

[guillaumedebavelaere]

done

[mitochondrion]

Make this into a guard-style if statement like above so that you don't need the giant if/else block.

if (cryptoAccount == null) {
    showAlert("previewTradeFirstLinkedBroker", "No crypto account!");
    return;
}

// Do other stuff here

[mitochondrion]

Why does this need to be a companion object? Why can't it just be a private instance method?

[guillaumedebavelaere]

This was a static method for non crypto order, so I took the same code

[mitochondrion]

See my comment on the Java version about using guard-style statements to avoid large/nested blocks.

[guillaumedebavelaere]

done

[mitochondrion]

This can be simplified further so that it doesn't continue iterating once you have found the first crypto account:

val cryptoAccount = linkedBrokers.firstOrNull { linkedBroker ->
    linkedBroker.accounts.firstOrNull { account ->
        it.getOrderCapabilityForInstrument(Instrument.CRYPTO) != null
    } != null
}

(You can use firstOrNull or find as they both do the same thing if you pass a predicate)

[guillaumedebavelaere]

This doesn't compile. We need to return a TradeItLinkedBrokerAccountParcelable

[gigiyy]

you'll need to use map or mapNonNull instead of find or first

[mitochondrion]

Ah sorry, I am reviewing this from my laptop and I don't have intellij.