Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hmrc 402 | Refactor search functionality #2131

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Hmrc 402 | Refactor search functionality #2131

wants to merge 18 commits into from

Conversation

EraliaKats
Copy link
Contributor

@EraliaKats EraliaKats commented Dec 12, 2024 •
edited
Loading

Jira link

HMRC-402

What?

I have added/removed/altered:

  • Refactored search form to use partial everywhere it's used (removed stimulus)
  • Removed redundant capybara tests

Why?

I am doing this because:

  • Simplifying codebase
  • Preparing for a larger refactor

@EraliaKats EraliaKats changed the title Hmrc 402 Hmrc 402 | Refactor search functionality Dec 24, 2024
@EraliaKats EraliaKats marked this pull request as ready for review December 24, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EraliaKats @neilmiddleton