HOTT-4629: Improve exception handling #1769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… HOTT-4629-error-controller # Conflicts: # app/controllers/errors_controller.rb
willfish
force-pushed
the
HOTT-4629-error-controller
branch
from
d858855 to
a8f9b13
Compare
willfish
reviewed
Dec 20, 2023
willfish
reviewed
Dec 20, 2023
alexdesi
force-pushed
the
HOTT-4629-error-controller
branch
6 times, most recently
from
55d56ad to
df28667
Compare
alexdesi
changed the title
alexdesi
reviewed
Dec 20, 2023
alexdesi
reviewed
Dec 20, 2023
| # Show full error reports and disable caching. | ||
| config.consider_all_requests_local = true | ||
| config.consider_all_requests_local = false |
There was a problem hiding this comment.
The application will render the public error pages instead of detailed debug information.
Removed redundant views for error messages (reusing error.html.erb) Support more errors in the routes.
alexdesi
force-pushed
the
HOTT-4629-error-controller
branch
from
df28667 to
77b4cd9
Compare
alexdesi
reviewed
Dec 20, 2023
| @@ -0,0 +1,51 @@ | |||
| RSpec.describe ApplicationController, type: :request do | |||
There was a problem hiding this comment.
I reconsidered the usefulness of these specs.
We can remove these. We are just (re)testing the mappings in the rails actionpack/lib/action_dispatch/middleware/exception_wrapper.rb are correct.
The useful tests are the spec/requests/errors_controller_spec.rb,
since the tests the routes and the rendered views.
Set consider_all_requests_local to true on Dev (to see detailed error reports).
alexdesi
force-pushed
the
HOTT-4629-error-controller
branch
from
49c24cf to
5445c5f
Compare
willfish
reviewed
Dec 22, 2023
willfish
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira link
HOTT-4629
What?
I have added/removed/altered:
error.html.erbviewWhy?
I am doing this because: