Merge pull request #1725 from trade-tariff/HOTT-5132-rename-gl-cat-as…

…sessment HOTT-5132 Rename entity to CategoryAssessment
trade-tariff · Feb 15, 2024 · 54bf440 · 54bf440
2 parents 8cc6f01 + bf20850
commit 54bf440
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/app/serializers/api/v2/green_lanes/category_assessment_serializer.rb b/app/serializers/api/v2/green_lanes/category_assessment_serializer.rb
@@ -4,7 +4,7 @@ module GreenLanes
       class CategoryAssessmentSerializer
         include JSONAPI::Serializer
 
-        set_type :green_lanes_category_assessment
+        set_type :category_assessment
 
         set_id :id
 

diff --git a/app/serializers/api/v2/green_lanes/goods_nomenclature_serializer.rb b/app/serializers/api/v2/green_lanes/goods_nomenclature_serializer.rb
@@ -17,7 +17,7 @@ class GoodsNomenclatureSerializer
                    :description_plain,
                    :producline_suffix
 
-        has_many :applicable_category_assessments, record_type: :green_lanes_category_assessment, serializer: Api::V2::GreenLanes::CategoryAssessmentSerializer
+        has_many :applicable_category_assessments, record_type: :category_assessment, serializer: Api::V2::GreenLanes::CategoryAssessmentSerializer
       end
     end
   end

diff --git a/spec/serializers/api/v2/green_lanes/category_assessment_serializer_spec.rb b/spec/serializers/api/v2/green_lanes/category_assessment_serializer_spec.rb
@@ -26,7 +26,7 @@
     {
       data: [
         id: be_a(String),
-        type: 'green_lanes_category_assessment',
+        type: 'category_assessment',
         attributes: {
           category: '1',
           theme: '1.1 Sanctions',

diff --git a/spec/serializers/api/v2/green_lanes/goods_nomenclature_serializer_spec.rb b/spec/serializers/api/v2/green_lanes/goods_nomenclature_serializer_spec.rb
@@ -35,7 +35,7 @@
           "applicable_category_assessments": {
             "data": [{
               "id": GreenLanes::CategoryAssessment.all[0].id,
-              type: eq(:green_lanes_category_assessment),
+              type: eq(:category_assessment),
             }],
           },
         },
@@ -47,7 +47,7 @@
         },
         {
           id: GreenLanes::CategoryAssessment.all[0].id,
-          type: eq(:green_lanes_category_assessment),
+          type: eq(:category_assessment),
           relationships: {
             measures: {
               data: [