-
Notifications
You must be signed in to change notification settings - Fork 15
chore(ci+cd): improve docker build #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
doronkopit5
wants to merge
11
commits into
main
Choose a base branch
from
dk/attempt_better_docker
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
bdd98b8
lets see times
doronkopit5 2cb1acb
separate
doronkopit5 f68efc4
just ubuntu
doronkopit5 14476ef
just test time changes
doronkopit5 5ee2831
rev
doronkopit5 8ab6d17
Merge branch 'main' into dk/attempt_better_docker
doronkopit5 1cae0db
Merge branch 'main' of github.com:traceloop/hub into dk/attempt_bette…
doronkopit5 79c92c6
test on ci
doronkopit5 9c2d664
test again
doronkopit5 8a25545
try like this
doronkopit5 e767cb4
lets see
doronkopit5 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,39 @@ | ||
FROM rust:1.82-bookworm AS builder | ||
|
||
FROM lukemathwalker/cargo-chef:latest-rust-1.82 AS chef | ||
WORKDIR /app | ||
|
||
# Planner stage - analyze dependencies | ||
FROM chef AS planner | ||
COPY . . | ||
RUN cargo chef prepare --recipe-path recipe.json | ||
|
||
# Builder stage with dependency caching | ||
FROM chef AS builder | ||
COPY --from=planner /app/recipe.json recipe.json | ||
# Build dependencies - this is the key caching layer | ||
RUN cargo chef cook --release --recipe-path recipe.json | ||
# Now build application code | ||
COPY . . | ||
RUN cargo build --release --bin hub | ||
|
||
FROM debian:bookworm-slim AS runtime | ||
RUN apt-get update && apt-get install -y openssl ca-certificates | ||
# Runtime stage - using Alpine for smaller image | ||
FROM alpine:3.19 AS runtime | ||
# Install SSL certificates and minimal dependencies | ||
RUN apk add --no-cache ca-certificates openssl libgcc | ||
|
||
# Create a non-root user to run the application | ||
RUN addgroup -S app && adduser -S app -G app | ||
WORKDIR /app | ||
COPY --from=builder /app/target/release/hub /usr/local/bin | ||
WORKDIR /etc | ||
|
||
ENV PORT 3000 | ||
# Only copy the built binary | ||
COPY --from=builder /app/target/release/hub /usr/local/bin/ | ||
RUN chmod +x /usr/local/bin/hub | ||
|
||
# Set environment variables | ||
ENV PORT=3000 | ||
EXPOSE 3000 | ||
|
||
ENTRYPOINT ["/usr/local/bin/hub"] | ||
# Use non-root user for better security | ||
USER app | ||
|
||
# Set the entrypoint | ||
ENTRYPOINT ["/usr/local/bin/hub"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -102,7 +102,7 @@ pub async fn chat_completions( | |||||
} | ||||||
} | ||||||
|
||||||
tracer.log_error("No matching model found".to_string()); | ||||||
tracer.log_error("No matching model found ".to_string()); | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Extra trailing space in log message; remove it to match other endpoints.
Suggested change
|
||||||
eprintln!("No matching model found for: {}", payload.model); | ||||||
Err(StatusCode::NOT_FOUND) | ||||||
} | ||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Job name 'Docker Build and' appears truncated. Consider using a complete, descriptive name.