Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chapter to book for nightly use #2762

Closed
wants to merge 1 commit into from

Conversation

bioinformatist
Copy link
Contributor

One may meet this problem when use Burn and another crate with hashbrown=^0.14 or earlier simultaneously.

8d8b6f70392272c36efdde952b4af3f

Similar to rust-lang/hashbrown#564.

In our case, the older version of hashbrown is used by dashmap.

I've tried to add new feature flags to Burn, but it soon became a tedious business.

Another way is to add alias for older hashbrown like what the polars has done: https://github.com/pola-rs/polars/pull/19091/files, but I think it's not elegant enough as it can also be complicated.

So maybe the better way is to tell the users the solution in the book.

For more info: rust-lang/hashbrown#564 and zakarumych/allocator-api2#19.

Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing the steps and links!

I agree that having something like this documented is helpful for future reference, but I'm not sure we should add a nightly section to the book just for this.

Perhaps it could be left as an outstanding issue so users can easily refer to it? Open to suggestions.

@bioinformatist
Copy link
Contributor Author

bioinformatist commented Feb 5, 2025

I'm not sure we should add a nightly section to the book just for this

I also feel something strange here 😅 since this issue may be solved by stable Rust in the future. Or let's move it to a pinned issue?

@laggui
Copy link
Member

laggui commented Feb 5, 2025

I also feel something strange here 😅 since this issue may be solved by stable Rust in the future. Or let's move it to a pinned issue?

A pinned issue for nightly stuff already makes more sense 😄

@laggui
Copy link
Member

laggui commented Feb 11, 2025

Closing as discussed. Feel free to open an issue with the description and solution.

@laggui laggui closed this Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants