Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add speed color legend #1294

Merged
merged 4 commits into from
Nov 5, 2024
Merged

Add speed color legend #1294

merged 4 commits into from
Nov 5, 2024

Conversation

jcardus
Copy link
Contributor

@jcardus jcardus commented Nov 4, 2024

Screenshot 2024-11-04 at 17 00 47

@jcardus
Copy link
Contributor Author

jcardus commented Nov 4, 2024

Screenshot 2024-11-04 at 16 50 07

@tananaev
Copy link
Member

tananaev commented Nov 4, 2024

I think this is overkill. I don't want to add more controls just for speed.

@jcardus
Copy link
Contributor Author

jcardus commented Nov 4, 2024

It goes out when we leave route replay

@tananaev
Copy link
Member

tananaev commented Nov 4, 2024

I understand, but still it takes a lot of space.

@jcardus
Copy link
Contributor Author

jcardus commented Nov 4, 2024

any suggestion?

@tananaev
Copy link
Member

tananaev commented Nov 4, 2024

I think more reasonable would be to maybe show some markers on the map to indicate speed. Maybe show it on hover only.

@jcardus
Copy link
Contributor Author

jcardus commented Nov 4, 2024

This way you get a quick idea of the speeding (where and how much). Maybe I can put it smaller.

@jcardus
Copy link
Contributor Author

jcardus commented Nov 4, 2024

Smaller version...

localhost_3000_(iPhone 12 Pro) (1)

@tananaev
Copy link
Member

tananaev commented Nov 4, 2024

Looks better. Can we make text the same style as the distance control? We can also probably round to 1 or even 0 digits. And maybe we don't need the middle point. Then we can reduce the width even more.

@jcardus
Copy link
Contributor Author

jcardus commented Nov 5, 2024

here it goes

localhost_3000_replay(iPhone 12 Pro) (2)

@jcardus jcardus requested a review from tananaev November 5, 2024 17:17
@tananaev tananaev merged commit 6c953ac into traccar:master Nov 5, 2024
1 check passed
@tananaev
Copy link
Member

tananaev commented Nov 5, 2024

Looks good, thank you.

@jcardus jcardus deleted the speed-legend branch November 5, 2024 20:01
@hypoclone
Copy link

Hello @jcardus and @tananaev, thank you guys for the great work you do. i don't know if it is ok to discuss it here or create another discussion on it, but i think it will be intuitive to have the replay track show stops and stops duration with an icon i.e

2024-11-10.22-07-43.mp4

@jcardus
Copy link
Contributor Author

jcardus commented Nov 10, 2024

Maybe it's better to create a feature request, probably for the combined report which already has some of that information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants